Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for windows build for node-sqlcipher 5.0.0 #60

Closed
wants to merge 6 commits into from
Closed

fix for windows build for node-sqlcipher 5.0.0 #60

wants to merge 6 commits into from

Conversation

dev-manager-uk
Copy link

No description provided.

@dev-manager-uk
Copy link
Author

not sure what happend with deps/sqlcipher-amalgamation-3031000 - I think you can ignore that if it wants to change.

Main thing is changing:

#if NAPI_VERSION < 6 || TRUE

@rkistner
Copy link
Member

Thanks for the work here.

The if statements were introduced upstream here to fix a different issue related to worker threads: TryGhost/node-sqlite3#1367

However, it appears like there are multiple issues related to the N-API 6 version, so it may be better to just disable N-API 6 and worker thread support for now.

@rkistner
Copy link
Member

Thanks for the PR. I've now done a thorough investigation, and the issue is caused by electron-rebuild not supporting the {napi_build_version} variable. However, this is important for worker thread support, so I've added notes on another workaround here: #64

@rkistner rkistner closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants